[
https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554115#comment-14554115
]
Robert Muir commented on LUCENE-6494:
-------------------------------------
Can we reduce the number of classes here for this api?
I see:
* SpanCollector
* SpanCollectorFactory
* BufferedSpanCollector
* MatchData
* MatchDataCollector
* MatchDataIterator
* MatchOffset
* MatchPosition
* MatchPayload
A great number of these have complex generics, is this really required?
Finally, a good number of methods are unnatural, like this:
{code}
public int requiredPositions()
{code}
Please use regular names like get() and set(). I know such "fluent" names are
fashionable, but they are bullshit :), because you cannot tell based on any
convention if they are simply returning stuff or changing mutable state or what.
> Make PayloadSpanUtil apply to other postings information
> --------------------------------------------------------
>
> Key: LUCENE-6494
> URL: https://issues.apache.org/jira/browse/LUCENE-6494
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Fix For: 5.2
>
> Attachments: LUCENE-6494.patch
>
>
> With the addition of SpanCollectors, we can now get arbitrary postings
> information from SpanQueries. PayloadSpanUtil does some rewriting to convert
> non-span queries into SpanQueries so that it can collect payloads. It would
> be good to make this more generic, so that we can collect any postings
> information from any query (without having to make invasive changes to
> already optimized Scorers, etc).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
