[ https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554547#comment-14554547 ]
David Smiley commented on LUCENE-6494: -------------------------------------- I'm looking over your latest patch, with an eye for it's suitability for accurate highlighting (aka "query debugging"). Ultimately, the "term" needs to be collected, and it isn't done so by MatchData/SpanCollector now. It seems an approach would involve a custom SpanCollector subclass that captures the term -- at least it's passed in already. But SpanCollector is instantiated internally by PayloadTermSpanScorer, SpanPayloadCheckQuery, and SpanNearPayloadCheckQuery. I was hoping there would be some way to pass in a custom one into SpanWeight from the outside; that is/was the case but this API change removes that. I do think this looks/feels nicer though; but it loses a capability -- albeit one it only had for a couple days now. What do you think Alan? > Make PayloadSpanUtil apply to other postings information > -------------------------------------------------------- > > Key: LUCENE-6494 > URL: https://issues.apache.org/jira/browse/LUCENE-6494 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Fix For: 5.2 > > Attachments: LUCENE-6494.patch, LUCENE-6494.patch, LUCENE-6494.patch, > LUCENE-6494.patch > > > With the addition of SpanCollectors, we can now get arbitrary postings > information from SpanQueries. PayloadSpanUtil does some rewriting to convert > non-span queries into SpanQueries so that it can collect payloads. It would > be good to make this more generic, so that we can collect any postings > information from any query (without having to make invasive changes to > already optimized Scorers, etc). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org