[ https://issues.apache.org/jira/browse/LUCENE-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987407#action_12987407 ]
Shai Erera commented on LUCENE-914: ----------------------------------- The method currently has this in its jdocs: {noformat} * <b>NOTE:</b> certain implementations may return a different value (each * time) if called several times in a row with the same target. {noformat} I think we need to collapse it with your proposal somehow. Both statements are slightly inaccurate IMO because: * Current uses cumbersome wording. * Proposal says "... intended for use with target > current otherwise ..." but I think it's a bit fuzzy also. Maybe something like this: {noformat} * <b>NOTE:</b> some implementations may not advance beyond their current {@link #docID()} if {@code current == target}. {noformat} What do you think? Also, while we're at it, there's a wrong {@value} reference in the jdocs which should be {@link} - the jdocs look awkward with {@value} when generated. > Scorer.skipTo(current) remains on current for some scorers > ---------------------------------------------------------- > > Key: LUCENE-914 > URL: https://issues.apache.org/jira/browse/LUCENE-914 > Project: Lucene - Java > Issue Type: Bug > Components: Search > Reporter: Doron Cohen > Priority: Minor > Attachments: lucene-914.patch > > > Background in http://www.nabble.com/scorer.skipTo%28%29-contr-tf3880986.html > It appears that several scorers do not strictly follow the spec of > Scorer.skipTo(n), and skip to current location remain in current location > whereas the spec says: "beyond current". > We should (probably) either relax the spec or fix the implementations. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org