[
https://issues.apache.org/jira/browse/LUCENE-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987502#action_12987502
]
Robert Muir commented on LUCENE-2609:
-------------------------------------
bq. I don't think this should hold us back when maintaining tests. It's like
"ant eclipse/idea/maven" - not too many guarantees besides "we're gonna do the
best we can to maintain it" (it being the .jar, not tests).
except its called from 'ant package', so I will see 'BUILD FAILED' if i
refactor something that breaks this (lets say I split up LuceneTestCase, etc).
Furthermore, take an example where i add something to LuceneTestCase, where it
reads data from a 10MB file, or something that breaks this design.
If my idea is good for tests, it should be committed, and not "reconsidered
because of test.jar packaging".
This example is a totally ridiculous/absurd/extreme one: but there are also
cases not-so-extreme.
I think its vital that its easy for us to be able to refactor tests with
wreckless abandon with only three goals in mind:
# Test Coverage
# Test Coverage
# Test Coverage
I am getting worried that src/test starts getting held to a "higher standard"
here, when its a tool to ensure test coverage.
I agree when possible, we should try to keep the code quality high in src/test,
but this is really just completely optional.
> Generate jar containing test classes.
> -------------------------------------
>
> Key: LUCENE-2609
> URL: https://issues.apache.org/jira/browse/LUCENE-2609
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Build
> Affects Versions: 3.0.2
> Reporter: Drew Farris
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2609.patch, LUCENE-2609.patch, LUCENE-2609.patch
>
>
> The test classes are useful for writing unit tests for code external to the
> Lucene project. It would be helpful to build a jar of these classes and
> publish them as a maven dependency.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
