[ 
https://issues.apache.org/jira/browse/LUCENE-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560775#comment-14560775
 ] 

Robert Muir commented on LUCENE-6371:
-------------------------------------

Sorry, I am not very clear. I don't understand why SpanWeight needs to take 
nulls, or TermContext stuff at all.

Why can't it work like today? If someone Span* impl needs to know when scoring 
is not needed, add {{boolean needsScores}} to SpanWeight's ctor, rather than 
some magic null value. TermContexts map is an impl detail, not an API. Lets not 
let it become one, its too messy for that.

> Improve Spans payload collection
> --------------------------------
>
>                 Key: LUCENE-6371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6371
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: Trunk, 5.3
>
>         Attachments: LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch, 
> LUCENE-6371.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to