[ 
https://issues.apache.org/jira/browse/LUCENE-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562834#comment-14562834
 ] 

Alan Woodward commented on LUCENE-6371:
---------------------------------------

I think it's still useful though - I use it all the time!  It would be nice if 
you could restrict the number of SpanOr clauses it rewrites to, but that's a 
separate issue.

If you really think that moving .getSpans() and .extractTerms() to SpanWeight 
doesn't gain anything, then I can back it out.  But I think it does simplify 
the API and brings it more into line with our other standard queries.  And I 
really don't see that exposing the termcontexts map on the SpanWeight 
constructor is any worse than exposing it directly in .getSpans().  In fact, 
I'd say that it's hiding it better - very few users of lucene are going to be 
looking at SpanWeights, as they're an implementation detail, but anyone using 
an IDE is going to be shown SpanQuery.getSpans() when they try and autocomplete 
on a SpanQuery object, and it's not something that most users need to worry 
about.

> Improve Spans payload collection
> --------------------------------
>
>                 Key: LUCENE-6371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6371
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: Trunk, 5.3
>
>         Attachments: LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch, 
> LUCENE-6371.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to