[
https://issues.apache.org/jira/browse/LUCENE-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572843#comment-14572843
]
Ryan Ernst commented on LUCENE-5954:
------------------------------------
Thanks Mike! This looks great.
A couple questions:
* Do we really need to add compareTo? Couldn't we use the existing onOrAfter?
It seems weird to have two ways of comparing versions.
* Is there somewhere we could have a more direct test than deletion policy
tests? I took a quick look but couldn't find anything unit testing the segment
infos reading/writing...
> Store lucene version in segment_N
> ---------------------------------
>
> Key: LUCENE-5954
> URL: https://issues.apache.org/jira/browse/LUCENE-5954
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Ryan Ernst
> Assignee: Michael McCandless
> Attachments: LUCENE-5954.patch
>
>
> It would be nice to have the version of lucene that wrote segments_N, so that
> we can use this to determine which major version an index was written with
> (for upgrading across major versions). I think this could be squeezed in
> just after the segments_N header.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
