[ 
https://issues.apache.org/jira/browse/LUCENE-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572876#comment-14572876
 ] 

Robert Muir commented on LUCENE-5954:
-------------------------------------

{code}
if (format >= VERSION_53) {
  // TODO: in the future (7.0?  sigh) we can use this to throw 
IndexFormatTooOldException ... or just rely on the
  // minSegmentLuceneVersion check instead:
  infos.luceneVersion = Version.fromBits(input.readVInt(), input.readVInt(), 
input.readVInt());
} else {
  // else leave null
}
{code}

I guess I was hoping we could take it further. We dont technically need to 
change file formats to implement this, it could be computed from the segments 
on read in the 4.0-5.2 case? Its just the min() that it finds there. Or does 
this become too hairy?



> Store lucene version in segment_N
> ---------------------------------
>
>                 Key: LUCENE-5954
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5954
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>            Assignee: Michael McCandless
>         Attachments: LUCENE-5954.patch
>
>
> It would be nice to have the version of lucene that wrote segments_N, so that 
> we can use this to determine which major version an index was written with 
> (for upgrading across major versions).  I think this could be squeezed in 
> just after the segments_N header.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to