[ https://issues.apache.org/jira/browse/SOLR-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901449#comment-14901449 ]
Anshum Gupta commented on SOLR-8069: ------------------------------------ This makes sense and it's also pretty contained. Here are a suggestions: * That should be CoreDescriptor in the comment. {code:title=ZkController.java} + leaderCd); // core node name of current leader {code} * Unused import MockCoreContainer in HttpPartitionTest * In ZkController.markShardAsDownIfLeader(), was the move from using getLeaderSeqPath to {{new org.apache.hadoop.fs.Path(((ShardLeaderElectionContextBase)context).leaderPath).getParent().toString()}} intentional ? > Ensure that only the valid ZooKeeper registered leader can put a replica into > Leader Initiated Recovery. > -------------------------------------------------------------------------------------------------------- > > Key: SOLR-8069 > URL: https://issues.apache.org/jira/browse/SOLR-8069 > Project: Solr > Issue Type: Bug > Reporter: Mark Miller > Assignee: Mark Miller > Priority: Critical > Attachments: SOLR-8069.patch, SOLR-8069.patch > > > I've seen this twice now. Need to work on a test. > When some issues hit all the replicas at once, you can end up in a situation > where the rightful leader was put or put itself into LIR. Even on restart, > this rightful leader won't take leadership and you have to manually clear the > LIR nodes. > It seems that if all the replicas participate in election on startup, LIR > should just be cleared. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org