[ https://issues.apache.org/jira/browse/SOLR-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904408#comment-14904408 ]
Mark Miller commented on SOLR-8069: ----------------------------------- I was out on the phone last night - a fuller reply: bq. What happens if the leaderZkNodeParentVersion doesn't match? The leader cannot update the zk node as we want. bq. Presumably that's a possibility or else why add the check. It's the whole point of the patch? bq. I'm certainly not well versed in this area of the code but checking isLeader seems a little roundabount There is no reason to go to zk if we already know we are not the leader locally - what is roundabout about it? bq. What does that mean? That the fix worked?? > Ensure that only the valid ZooKeeper registered leader can put a replica into > Leader Initiated Recovery. > -------------------------------------------------------------------------------------------------------- > > Key: SOLR-8069 > URL: https://issues.apache.org/jira/browse/SOLR-8069 > Project: Solr > Issue Type: Bug > Reporter: Mark Miller > Assignee: Mark Miller > Priority: Critical > Attachments: SOLR-8069.patch, SOLR-8069.patch > > > I've seen this twice now. Need to work on a test. > When some issues hit all the replicas at once, you can end up in a situation > where the rightful leader was put or put itself into LIR. Even on restart, > this rightful leader won't take leadership and you have to manually clear the > LIR nodes. > It seems that if all the replicas participate in election on startup, LIR > should just be cleared. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org