[
https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942310#comment-14942310
]
Jack Krupansky commented on LUCENE-6821:
----------------------------------------
Won't this change have the prospect of increasing the amount of GC due to all
these extra objects?
Maybe might it be advisable to have an alternative constructor that doesn't
clone so that users like Solr can exploit the fact that their code won't be
making any further use of the input term?
> TermQuery's constructors should clone the incoming term
> -------------------------------------------------------
>
> Key: LUCENE-6821
> URL: https://issues.apache.org/jira/browse/LUCENE-6821
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-6821.patch
>
>
> This is a follow-up of LUCENE-6435: the bug stems from the fact that you can
> build term queries out of shared BytesRef objects (such as the ones returned
> by TermsEnum.next), which is a bit trappy. If TermQuery's constructors would
> clone the incoming term, we wouldn't have this trap.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
