[ https://issues.apache.org/jira/browse/LUCENE-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953138#comment-14953138 ]
Tommaso Teofili commented on LUCENE-6821: ----------------------------------------- do you mean the {{BytesRef.deepCopyOf}} at https://github.com/apache/lucene-solr/blob/trunk/lucene/classification/src/java/org/apache/lucene/classification/SimpleNaiveBayesClassifier.java#L154 ? yes, that's because the reference is updated and used in the {{ClassificationResult}}. I'll see if I can simplify that. > TermQuery's constructors should clone the incoming term > ------------------------------------------------------- > > Key: LUCENE-6821 > URL: https://issues.apache.org/jira/browse/LUCENE-6821 > Project: Lucene - Core > Issue Type: Task > Reporter: Adrien Grand > Priority: Minor > Attachments: LUCENE-6821.patch, LUCENE-6821.patch > > > This is a follow-up of LUCENE-6435: the bug stems from the fact that you can > build term queries out of shared BytesRef objects (such as the ones returned > by TermsEnum.next), which is a bit trappy. If TermQuery's constructors would > clone the incoming term, we wouldn't have this trap. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org