[
https://issues.apache.org/jira/browse/SOLR-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076659#comment-15076659
]
Yonik Seeley commented on SOLR-8475:
------------------------------------
bq. LOG is a static final field and I try to follow that convention with any
static-final field.
IMO, it's more about if the object is a constant, not if the reference is
final, and loggers aren't effectively immutable.
http://stackoverflow.com/questions/1417190/should-a-static-final-logger-be-declared-in-upper-case
Current frequency in the code base suggests that lowercase is our current
default.
{code}
/opt/code/lusolr$ find . -name \*.java | xargs grep "Logger LOG" | wc
78 624 14141
/opt/code/lusolr$ find . -name \*.java | xargs grep "Logger log" | wc
421 3315 71490
{code}
If we want to refactor and change all of one to the other, it seems like there
should be another JIRA issue and consensus around the issue.
{quote}
> Back compat breaks
True, but it's a really simple one to address
{quote}
If it requires recompilation, it's not back compat though.
> Some refactoring to SolrIndexSearcher
> -------------------------------------
>
> Key: SOLR-8475
> URL: https://issues.apache.org/jira/browse/SOLR-8475
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 5.5, Trunk
>
> Attachments: SOLR-8475.patch, SOLR-8475.patch, SOLR-8475.patch,
> SOLR-8475.patch
>
>
> While reviewing {{SolrIndexSearcher}}, I started to correct a thing here and
> there, and eventually it led to these changes:
> * Moving {{QueryCommand}} and {{QueryResult}} to their own classes.
> * Moving FilterImpl into a private static class (was package-private and
> defined in the same .java file, but separate class).
> * Some code formatting, imports organizing and minor log changes.
> * Removed fieldNames (handled the TODO in the code)
> * Got rid of usage of deprecated classes such as {{LegacyNumericUtils}} and
> {{Legacy-*-Field}}.
> I wish we'd cut down the size of this file much more (it's 2500 lines now),
> but I've decided to stop here so that the patch is manageable. I would like
> to explore further refactorings afterwards, e.g. extracting cache management
> code to an outer class (but keep {{SolrIndexSearcher}}'s API the same, if
> possible).
> If you have additional ideas of more cleanups / simplifications, I'd be glad
> to do them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
