On Mar 8, 2011, at 11:27 AM, Sanne Grinovero wrote: > 2011/3/8 Steven A Rowe <[email protected]>: >> Hi Sanne, >> >> Solr (and some Lucene modules) have several non-Mavenized dependencies.
In the past, we have usually published these along with Solr, by changing the names to be something like solr-foo.1.5.jar (see the commons-csv from 1.4) >> >> To work around this, the Maven build has a profile called "bootstrap". If >> you check out the source (or use the source distribution) you can place all >> non-Mavenized dependencies in your local repository as follows (from the >> top-level directory containing lucene, solr, etc.): >> >> ant get-maven-poms >> mvn -N -P bootstrap install >> >> Maybe there should also be a way to deploy these to an internal repository? >> >> Steve > > Hi Steve, > thank you for the answer. I'm not personally worried as I'm unaffected > by this issue, just thought to let the list know, so core developers > can evaluate how urgent it is. > > I'm not sold on the "several non-mavenized dependencies" argument: if > I adjust my pom locally to refer to a released Jetty version I have no > other build nor test issues, so this should be the only artifact > unless you refer to some other optional dependency. > > Also I used to depend on Solr in the past via maven, without issues - > so it looks to me that this is going to break expectations, as it > worked properly before. > > I'm totally fine with as long as you're all aware of it and making a > conscious decision, I don't think waiting for a Jetty release is a > reasonable option, but I'd add at least a warning in the release > notes. > > Regards, > Sanne > >> >>> -----Original Message----- >>> From: Sanne Grinovero [mailto:[email protected]] >>> Sent: Tuesday, March 08, 2011 6:44 AM >>> To: [email protected] >>> Subject: Re: [VOTE] Lucene and Solr 3.1 release candidate >>> >>> Hello, >>> the lucene-solr-grandparent pom [1] file mentions a jetty version >>> "6.1.26-patched-JETTY-1340" which is not available in the repositories >>> where I would expect it. >>> Do I need to enable some additional repository? >>> >>> This seems related to SOLR-2381. >>> >>> I think for people using Solr as their dependency via Maven, this is a >>> blocker; of course not everyone uses it so I've no strong opinions >>> about this, but thought to let you know. >>> Personally I'd depend on the released version of jetty, and document >>> that this bug is not fixed until Jetty version XY is released; in >>> alternative, I'd add keep the pom as is but instructions and warnings >>> in the release notes would be very welcome. (I couldn't find a >>> Chances.html for Solr?) >>> >>> Regards, >>> Sanne >>> >>> [1] http://people.apache.org/~rmuir/staging_area/lucene-solr-3.1RC0- >>> rev1078688/lucene-3.1RC0/maven/org/apache/lucene/lucene-solr- >>> grandparent/3.1.0/lucene-solr-grandparent-3.1.0.pom >>> >>> 2011/3/8 Shai Erera <[email protected]>: >>>> I found what seems to be a "glitch" in StopFilter's ctors -- the boolean >>>> 'enablePosInc' was removed from the ctors and users now have to use the >>>> setter instead. However, the ctors do default to 'true' if the passed in >>>> Version is onOrAfter(29). >>>> >>>> All of FilteringTokenFilter sub-classes include the enablePosIncr in >>> their >>>> ctors, including FilteringTF itself. Therefore I assume the parameter >>> was >>>> mistakenly dropped from StopFilter's ctors. Also, the @deprecated text >>>> doesn't mention how should I enable/disable it, and reading the source >>> code >>>> doesn't help either, since the setter/getter are in FilteringTF. >>>> >>>> Also, LengthFilter has a deprecated ctor, but the class was added on Nov >>> 16 >>>> and I don't see it in 3.0.3. So perhaps we can remove that ctor (and add >>> a >>>> @since tag to the class)? >>>> >>>> I don't know if these two warrant a new RC but I think they are >>> important to >>>> fix. >>>> >>>> Shai >>>> >>>> On Mon, Mar 7, 2011 at 5:52 PM, Smiley, David W. <[email protected]> >>> wrote: >>>>> >>>>> So https://issues.apache.org/jira/browse/SOLR-2405 didn't make it in >>>>> yesterday (apparently it didn't)? :-( Darn... maybe I shouldn't have >>> waited >>>>> for a committer to agree with the issue. I would have had it in >>> Saturday. >>>>> >>>>> ~ David Smiley >>>>> >>>>> On Mar 7, 2011, at 1:32 AM, Robert Muir wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> I have posted a release candidate for both Lucene 3.1 and Solr 3.1, >>>>>> both from revision 1078688 of >>>>>> http://svn.apache.org/repos/asf/lucene/dev/branches/lucene_solr_3_1/ >>>>>> Thanks for all your help! Please test them and give your votes, the >>>>>> tentative release date for both versions is Sunday, March 13th, 2011. >>>>>> Only votes from Lucene PMC are binding, but everyone is welcome to >>>>>> check the release candidates and voice their approval or disapproval. >>>>>> The vote passes if at least three binding +1 votes are cast. >>>>>> >>>>>> The release candidates are produced in parallel because in 2010 we >>>>>> merged the development of Lucene and Solr in order to produce higher >>>>>> quality releases. While we voted to reserve the right to release >>>>>> Lucene by itself, in my opinion we should definitely try to avoid >>> this >>>>>> unless absolutely necessary, as it would ultimately cause more work >>>>>> and complication: instead it would be far easier to just fix whatever >>>>>> issues are discovered and respin both releases again. >>>>>> >>>>>> Because of this, I ask that you cast a single vote to cover both >>>>>> releases. If the vote succeeds, both sets of artifacts can go their >>>>>> separate ways to the different websites. >>>>>> >>>>>> Artifacts are located here: http://s.apache.org/solrcene31rc0 >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [email protected] >>>>>> For additional commands, e-mail: [email protected] >>>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > -------------------------- Grant Ingersoll http://www.lucidimagination.com/ Search the Lucene ecosystem docs using Solr/Lucene: http://www.lucidimagination.com/search --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
