[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005190#comment-13005190 ]
Doron Cohen commented on LUCENE-2958: ------------------------------------- Thanks for reviewing Mike! No I didn't perf the perf task change.. :-) I will look at this again. Nice catch about the feild name. As for putting the field names in the file - let's see how this would work - we need a matching pair: LineDocWriter and LineDocSource, both should expect the same fields in same order, and, in addition, DocData has some fixed field names: ID, Body, Name, Date, Title, and a flexible Properties which can include anything else. If we move to put the field names in the header line as you suggest, that would make a single line-doc-source for any lineDocWriter which is nice, But that would require to modify DocData so that all fields - except for ID which would become mandatory - would be maintained in props. I like it, except perhaps for performance... what do you think? Is this what you have in mind? > WriteLineDocTask improvements > ----------------------------- > > Key: LUCENE-2958 > URL: https://issues.apache.org/jira/browse/LUCENE-2958 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/benchmark > Reporter: Doron Cohen > Assignee: Doron Cohen > Priority: Minor > Fix For: 3.2, 4.0 > > Attachments: LUCENE-2958.patch, LUCENE-2958.patch > > > Make WriteLineDocTask and LineDocSource more flexible/extendable: > * allow to emit lines also for empty docs (keep current behavior as default) > * allow more/less/other fields -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org