[ 
https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005612#comment-13005612
 ] 

Shai Erera commented on LUCENE-2958:
------------------------------------

bq. Really, it would be better if LineDocSource could directly set Field values.

That will break the separation we have today -- ContentSource returns DocData 
which is not a Lucene Document, and DocMaker creates a Document out of it. 
Remember that we were in this design before -- DocMaker was responsible for 
both parsing the content and creating a Document out of it. The current design 
is much more flexible.

bq. until then we should just pass the full String line to eg a processLine 
method

I agree. Either processLine or getDocData or whatever, but something which 
receives a line and returns DocData.

> WriteLineDocTask improvements
> -----------------------------
>
>                 Key: LUCENE-2958
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2958
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2958.patch, LUCENE-2958.patch
>
>
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to