[
https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006380#comment-13006380
]
Doron Cohen commented on LUCENE-2958:
-------------------------------------
Thanks for reviewing Mike!
bq. I think we should throw an exc if any of the field names contain the SEP
char?
Right, good catch!
bq. Can we name it "parseLine"
Yes, I like it better, readLine() felt wrong, parseLine it will be.
Also the inner class should better be called LineParser (rather than
DocDataLineReader).
I'll patch these - and fix the typo - totogether with more tests...
> WriteLineDocTask improvements
> -----------------------------
>
> Key: LUCENE-2958
> URL: https://issues.apache.org/jira/browse/LUCENE-2958
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch,
> LUCENE-2958.patch
>
>
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
