[
https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006145#comment-13006145
]
Shai Erera commented on LUCENE-2958:
------------------------------------
I haven't reviewed the patch yet, but I must say that from your description it
sounds like LineDocSource has become very complicated. I'd prefer to keep
things simple. Before this issue, LDS read a line and split it into 3 fields.
Now we think it should be extend-able, such that users can read lines and
tokenize them differently (for e.g. supporting more fields). I think that for
that, a getDocData/processLine extension point is enough.
After all, users can write their own WLDT and LDS, they don't have to use ours.
The purpose here is to keep the common logic in those two classes
(writing/reading lines to multiple in/output formats), only allow these classes
to be somewhat more flexible.
Therefore I think that the header line may not be that useful eventually. It
seems to only complicate matters. Most people (judging by the fact that it
hasn't come up as an issue yet) are either happy w/ the current capabilities,
or wrote their own matching pair to support more fields. So let's keep the
current impl as optimized as it was before, but allow for a simple extension
point?
> WriteLineDocTask improvements
> -----------------------------
>
> Key: LUCENE-2958
> URL: https://issues.apache.org/jira/browse/LUCENE-2958
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch
>
>
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
