[
https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167071#comment-15167071
]
Christine Poerschke commented on SOLR-8734:
-------------------------------------------
bq. ... to detect the existence of <mergeFactor> element in the .xml, and not
compare the value to the default. ...
If I understood you right this means to distinguish
{code}
...
<mergeFactor>-1</mergeFactor>
<mergePolicy...>...</mergePolicy...>
...
{code}
from
{code}
<mergePolicy...>...</mergePolicy...>
{code}
where -1 is the default value for the <mergeFactor> element. The motivation
perhaps being that when SOLR-8668 removes <mergePolicy> (and <mergeFactor>)
element support the {{<mergeFactor>-1</mergeFactor>}} likely would remain
behind as a zombie element?
Might we go even further than detecting the existence of a deprecated
<mergeFactor> element and detect any and all unsupported elements? Unsupported
elements could be simple typos on part of the user e.g. {{<mergePolicyFactor>}}
instead of {{<mergePolicyFactory>}} or they could be misplaced elements e.g.
[test-files/solr/collection1/conf/solrconfig-spellcheckcomponent.xml|https://github.com/apache/lucene-solr/blob/master/solr/core/src/test-files/solr/collection1/conf/solrconfig-spellcheckcomponent.xml#L34]
seems to have {{indexConfig/query/maxWarmingSearchers}} when possibly
{{query/maxWarmingSearchers}} was intended (SOLR-8682 exists for that).
> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --------------------------------------------------------------
>
> Key: SOLR-8734
> URL: https://issues.apache.org/jira/browse/SOLR-8734
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.5, master
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5, <maxMergeDocs> is deprecated,
> configure it on the relevant <mergePolicyFactory> instead.
> ...
> bq. On my development machine for all cores. None of the cores has either
> parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a <mergePolicy> element
> (for which deprecated warnings would appear separately) or that the
> solrconfig.xml has no <mergePolicyFactory> element?
> ...
> bq. If either is the case then yes based on the code
> (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless
> though admittedly are confusing, and fixable.
> ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
