[ https://issues.apache.org/jira/browse/LUCENE-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175658#comment-15175658 ]
David Smiley commented on LUCENE-7056: -------------------------------------- So gents where does this leave us in terms of specific package naming to separate them? I made a recommendation; do you like it? * org.apache.lucene.spatial.3d gets the 2 Lucene classes. * org.apache.lucene.spatial.3d.geom (most of the current code goes here; it implements the geometries) The aspects of this I like the most are that it has "spatial" as an intermediate package (it's spatial after all; no denying that), and that it uses "geom" short for geometry for the computational geometry code. I don't particularly like "3d" but I have no better ideas right now. Perhaps "geo3d" to be consistent with the original (& current) branding? So just to be clear, Mike & Rob feel that keeping the 2 Lucene dependent classes here is better than separating them into different modules? I don't agree but so be it. > Spatial3d/Geo3d should have zero runtime dependencies > ----------------------------------------------------- > > Key: LUCENE-7056 > URL: https://issues.apache.org/jira/browse/LUCENE-7056 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial3d > Reporter: David Smiley > Assignee: David Smiley > Fix For: 6.0 > > > This is a proposal for the "spatial3d" module to be purely about the > shape/geometry implementations it has. In Lucene 5 that's actually all it > has. In Lucene 6 at the moment its ~76 files have 2 classes that I think > should go elsewhere: Geo3DPoint and PointInGeo3DShapeQuery. Specifically > lucene-spatial-extras (which doesn't quite exist yet so lucene-spatial) would > be a suitable place due to the dependency. _Eventually_ I see this module > migrating elsewhere be it on its own or a part of something else more > spatial-ish. Even if that never comes to pass, non-Lucene users who want to > use this module for it's geometry annoyingly have to exclude the Lucene > dependencies that are there because this module also contains these two > classes. > In a comment I'll suggest some specifics. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org