[
https://issues.apache.org/jira/browse/LUCENE-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178199#comment-15178199
]
Robert Muir commented on LUCENE-7063:
-------------------------------------
I'm gonna update this patch after investigating the tests.
TestLegacyNumericUtils has a lot of nice unit tests, we should make sure none
of these "get lost" in the sense, they are probably still possible to port
forward to the new full byte[] range encoding and so on. I think this makes
sense to just solve all here, so we know floats and doubles are really totally
working correct and other things that are super important for core numeric
fields.
> NumericUtils vs LegacyNumericUtils chaos with 6.0
> -------------------------------------------------
>
> Key: LUCENE-7063
> URL: https://issues.apache.org/jira/browse/LUCENE-7063
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-7063.patch
>
>
> Old prefix-coded terms helper functions are still available in
> LegacyNumericUtils, but its confusing when upgrading because NumericUtils and
> LegacyNumericUtils have overlaps in the APIs.
> One issue is they share some exact methods that are completely unrelated to
> this encoding (e.g. floatToSortableInt). The method is just duplication and
> worst, most lucene code is still calling it from LegacyNumericUtils, even
> stuff like faceting code using it with docvalues.
> Another issue is the new NumericUtils methods (which use full byte range)
> have vague names, no javadocs, expose helper methods as public unnecessarily,
> and cause general confusion.
> I don't think NumericUtils and LegacyNumericUtils should overlap.
> LegacyNumericUtils should only contain legacy stuff!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
