[
https://issues.apache.org/jira/browse/LUCENE-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179278#comment-15179278
]
ASF subversion and git services commented on LUCENE-7063:
---------------------------------------------------------
Commit 2aa412132d0a32ab8c9fab538ba55bf09d24cd90 in lucene-solr's branch
refs/heads/branch_6_0 from [~rcmuir]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2aa4121 ]
LUCENE-7063: add tests/docs for numericutils, rename confusing methods, remove
overlap with LegacyNumericUtils
> NumericUtils vs LegacyNumericUtils chaos with 6.0
> -------------------------------------------------
>
> Key: LUCENE-7063
> URL: https://issues.apache.org/jira/browse/LUCENE-7063
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: master, 6.0
>
> Attachments: LUCENE-7063.patch, LUCENE-7063.patch
>
>
> Old prefix-coded terms helper functions are still available in
> LegacyNumericUtils, but its confusing when upgrading because NumericUtils and
> LegacyNumericUtils have overlaps in the APIs.
> One issue is they share some exact methods that are completely unrelated to
> this encoding (e.g. floatToSortableInt). The method is just duplication and
> worst, most lucene code is still calling it from LegacyNumericUtils, even
> stuff like faceting code using it with docvalues.
> Another issue is the new NumericUtils methods (which use full byte range)
> have vague names, no javadocs, expose helper methods as public unnecessarily,
> and cause general confusion.
> I don't think NumericUtils and LegacyNumericUtils should overlap.
> LegacyNumericUtils should only contain legacy stuff!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
