[
https://issues.apache.org/jira/browse/LUCENE-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009020#comment-13009020
]
Shai Erera commented on LUCENE-2964:
------------------------------------
Patch looks good and nice updates to package.html !
In Algorithm.taskClass, I see that you store the CNFE and later reference it in
the thrown CNFE (if the class wasn't found in all package). I think it's
redundant? Because if I specify 4 alt packages and the task is not in any of
them, the referenced error will be of the last one, which is just confusing.
The CNFE message that you pass is already descriptive enough, IMO.
Can we put AltTestTask an inner public static member of AltPackageTaskTest?
> Allow benchmark tasks from alternative packages
> -----------------------------------------------
>
> Key: LUCENE-2964
> URL: https://issues.apache.org/jira/browse/LUCENE-2964
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2964.patch, LUCENE-2964.patch
>
>
> Relax current limitation of all tasks in same package - that of PerfTask.
> Add a property "alt.tasks.packages" - its value are comma separated full
> package names.
> If the task class is not found in the default package, an attempt is made to
> load it from the alternate packages specified in that property.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
