[ 
https://issues.apache.org/jira/browse/LUCENE-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009060#comment-13009060
 ] 

Doron Cohen commented on LUCENE-2964:
-------------------------------------

Thanks for reviewing.

bq. The CNFE message that you pass is already descriptive enough, IMO.

Agree, I'll change that.

bq. put AltTestTask an inner public static member of AltPackageTaskTest

This makes sense - but is tricky, as the alg line should now look like this:

{code}
String altTask = "{ AltPackageTaskTest$AltTest }"; // inner class peculiarities 
- '$' as separator
{code}

Which is rather not too nice (took me some time to figure why just 
*AltPackageTaskTest.AltTest* fails).
But in addition, *$* causes the Algorithm's tokenizer to break that into two 
task names, I am not sure it is worth to modify it for removing that test 
class, but I'll give it a few more minutes. 

> Allow benchmark tasks from alternative packages
> -----------------------------------------------
>
>                 Key: LUCENE-2964
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2964
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2964.patch, LUCENE-2964.patch
>
>
> Relax current limitation of all tasks in same package - that of PerfTask.
> Add a property "alt.tasks.packages" - its value are comma separated full 
> package names.
> If the task class is not found in the default package, an attempt is made to 
> load it from the alternate packages specified in that property.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to