[
https://issues.apache.org/jira/browse/LUCENE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009796#comment-13009796
]
Shai Erera commented on LUCENE-2980:
------------------------------------
Patch looks good. Few tiny comments:
* Should ContentSourceTest extend BenchmarkTestCase?
* I think that instead of assertTrue(testDir.isDirectory()); you can
assertTrue(testDir.mkdirs());
* In case you wanted a second opinion about the "nocommit" lines, I think they
can all go away :).
> Benchmark's ContentSource should not rely on file suffixes to be lower cased
> when detecting file type (gzip/bzip2/text)
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2980
> URL: https://issues.apache.org/jira/browse/LUCENE-2980
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/benchmark
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2980.patch
>
>
> file.gz is correctly handled as gzip, but file.GZ handled as text which is
> wrong.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
