[
https://issues.apache.org/jira/browse/LUCENE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010043#comment-13010043
]
Doron Cohen commented on LUCENE-2980:
-------------------------------------
bq. Perhaps we should add a specific test in CSTest for this problem? I
wouldn't use file.delete() as in indicator because on Linux it will pass
Changed my mind about adding this test to ContentSourceTest - I think such a
test fits more to the CommonCompress project, because it should directly call
CompressorStreamFactory.createCompressorInputStream(in). In our test we invoke
ContentSource.getInputStream(File) and so we cannot pass such a close-sensing
stream.
But this is a valid point, especially, the test case I provided to COMPRESS-127
will fail on Windows but will likely pass on Linux. I'll add a reference to
your comment in COMPRESS-127.
> Benchmark's ContentSource should not rely on file suffixes to be lower cased
> when detecting file type (gzip/bzip2/text)
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2980
> URL: https://issues.apache.org/jira/browse/LUCENE-2980
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/benchmark
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2980.patch, LUCENE-2980.patch
>
>
> file.gz is correctly handled as gzip, but file.GZ handled as text which is
> wrong.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
