[ 
https://issues.apache.org/jira/browse/LUCENE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated LUCENE-7094:
---------------------------------
    Attachment: LUCENE_7094.patch

I uploaded another patch.  I mostly just focused on PointVectorStrategy because 
it's simpler than BBoxStrategy.  I touched SpatialTestCase (mostly restoring 
it) too.  I removed the docValue field suffix, and I'm unable to reproduce the 
issue with UninvertingReader you spoke of.  Might you see if it's really gone 
and if it isn't upload a patch that fails a test?

The main thing I did with PointVectorStrategy was to show how the various 
stored, docValues, pointValues, and legacyNumeric options can be configured by 
passing in a FieldType.  I want to get your opinion on this approach.  From an 
API standpoint, it's basically the same approach that BBoxStrategy takes, 
although I obviously did it without using the ComboField thing which maybe is 
too hacky and not worth it.

Let me know if you'd like to use Reviewboard; I'd like to so that we can better 
see what changes we're making... but I understand if you don't want to.

> spatial-extras BBoxStrategy and (confusingly!) PointVectorStrategy use legacy 
> numeric encoding
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7094
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7094
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Nicholas Knize
>         Attachments: LUCENE-7094.patch, LUCENE-7094.patch, LUCENE_7094.patch
>
>
> We need to deprecate these since they work on the old encoding and provide 
> points based alternatives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to