[
https://issues.apache.org/jira/browse/LUCENE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-7094:
---------------------------------
Attachment: LUCENE_7094.patch
Both BBoxStrategy & PointVectorStrategy:
* all state is now final; setters are removed. The constructor has everything
it needs to know. The constructor is public, and represents an alternative to
the static factory methods you added, for when the caller has options to
customize. *Perhaps instead this should be another factory method?*
* Options are set via a passed FieldType; and there’s a getter for it.
* The code for state, construction & createFields are very consistent now.
It’s a bit dejavu but it’s not clear refactoring to reduce duplication would be
worthwhile.
* no special name prefix is needed for DocValues based field. (same as it has
been)
* some javadocs updates; remove references to legacy numerics
BBoxStrategy:
* the internal ComboField is gone
PointVectorStrategy:
* consistency with BBoxStrategy now means this has some options formerly only
in BBoxStrategy: can be marked stored (default false), the index (be it
PointValues or legacy numeric) is optional (default true), and DocValues is
optional (default true). An error is thrown if you call makeQuery and there’s
no index.
Tests:
* Added test for being able to turn stored on/off, the index on/off on
PointVectorStrategy
* removed automatic use of UninvertedField, and the needsDocValues overrideable
method. Instead I added a utility method a test can invoke to introduce
UninvertedField with the specified list of fields and the UninvertedField.Type
(thus enabling testing uninverting of Double PointValues)). _I know we said
this could be another issue but it didn't take long and it's comforting to see
it works_
* TestBBoxStrategy now tests uninverting behavior and for both legacy &
pointValues
Misc:
* No changes to SpatialStrategy
> spatial-extras BBoxStrategy and (confusingly!) PointVectorStrategy use legacy
> numeric encoding
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-7094
> URL: https://issues.apache.org/jira/browse/LUCENE-7094
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Nicholas Knize
> Priority: Blocker
> Fix For: master, 6.0
>
> Attachments: LUCENE-7094.patch, LUCENE-7094.patch, LUCENE_7094.patch,
> LUCENE_7094.patch
>
>
> We need to deprecate these since they work on the old encoding and provide
> points based alternatives.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
