[ https://issues.apache.org/jira/browse/SOLR-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231146#comment-15231146 ]
Mike Drob commented on SOLR-8933: --------------------------------- bq. I would just use the CloseShieldInputStream. The additional APIs provided by ServletInputStream or ServletOutputStream are not used by Solr. Actually we put some of them to the forbidden-apis list (because of stupidity and ISO-8859-1 defaults from earlier days). See lucene/tools/forbiddenApis/servlet-api.txt Doesn't matter that we don't use the extra APIs, the type signature of {{ServletRequest::getInputStream}} still demands a {{ServletInputStream}} so that is what we have to return when wrapping the request object. The other option is to go even deeper down the hierarchy, cast to {{org.eclipse.jetty.server.Request}} and then manipulate the input stream directly from there, but that feels much more invasive and brittle. > SolrDispatchFilter::consumeInput logs "Stream Closed" IOException > ----------------------------------------------------------------- > > Key: SOLR-8933 > URL: https://issues.apache.org/jira/browse/SOLR-8933 > Project: Solr > Issue Type: Bug > Affects Versions: 4.10.3 > Reporter: Mike Drob > Assignee: Mark Miller > Attachments: SOLR-8933.patch, SOLR-8933.patch, SOLR-8933.patch, > SOLR-8933.patch > > > After SOLR-8453 we started seeing some IOExceptions coming out of > SolrDispatchFilter with "Stream Closed" messages. > It looks like we are indeed closing the request stream in several places when > we really need to be letting the web container handle their life cycle. I've > got a preliminary patch ready and am working on testing it to make sure there > are no regressions. > A very strange piece of this is that I have been entirely unable to reproduce > it on a unit test, but have seen it on cluster deployment quite consistently. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org