[
https://issues.apache.org/jira/browse/SOLR-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012981#comment-13012981
]
Robert Muir commented on SOLR-2002:
-----------------------------------
Hi Chris, so mainly i want to start with the patch where Solr's build system
extends Lucene's.
This gives us a 'single' build system (as the modules and lucene contrib
already extend lucene's) rather than the 4 or 5 we have now: as solr contribs
actually basically have their own standalone build.
So in lucene's common-build, we can easily add new targets/checks/functionality
(e.g. findbugs/failing on javadocs/etc) and it applies to everything.
Also in my tests this was a huge speedup to the solr build, especially things
like ant test -Dtestcase
But, there is a lot to do: in my patch i only did the basics (compile/test/etc).
* we need to implement things like solr 'example' tasks.
* we need to look at lucene and solr's build.xml and see what things are
duplicates, such as packaging tasks, that can be added to common-build.xml: an
example is artifact signing and hashing.
* i think it might be worth our time to look at antunit or something of that
nature to implement 'tests' for the build system. By this i don't really mean
tests that ensure our ant logic is correct: I mean automated tests that look at
whether things like packaging are correct. But i havent looked at antunit yet,
so I admittedly don't know what I am talking about.
* once everything is using a single common-build recursively, we should
consider additional features (pmd, findbugs, ...) that we would want to
implement to perform even more checks: this can really be separate issues but
its good to think right now about how we can make our build system as picky as
possible to try to keep the codebase in good shape.
> improve build/tests
> -------------------
>
> Key: SOLR-2002
> URL: https://issues.apache.org/jira/browse/SOLR-2002
> Project: Solr
> Issue Type: Task
> Components: Build
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 4.0, Next
>
> Attachments: SOLR-2002.junit.xml.formatter.patch, SOLR-2002.patch,
> SOLR-2002_buildfailed.patch, SOLR-2002_core_contrib.patch,
> SOLR-2002_dih.patch, SOLR-2002_lbhttpsolrserver.patch,
> SOLR-2002_localization.patch, SOLR-2002_lucenetestcase.patch,
> SOLR-2002_merged.patch, SOLR-2002_merged.patch, SOLR-2002_merged.patch,
> SOLR-2002_merged.patch, SOLR-2002_replication.patch,
> SOLR-2002_testiter.patch, SOLR-2002_testmethod.patch,
> SOLR-2002_timeout.patch, SOLR-2002setupteardown.patch,
> TEST-org.apache.solr.spelling.suggest.SuggesterTest.txt
>
>
> we are working on improving some functionality in lucene's build/tests, it
> would be good to improve the solr side to take advantage of it.
> currently its only sorta-kinda integrated and a bit messy.
> i'd like to do some incremental improvements piece-by-piece on this issue.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
