[
https://issues.apache.org/jira/browse/SOLR-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-8583:
------------------------------
Attachment: SOLR-8583.patch
New patch incorporating Davids comments:
* Changed order of params for {{doHighlightingOfField()}} and
{{alternateField()}}
* Added test for {{hl.requireFieldMatch=true}}
* Added test that proves that we get highlighting of fallback field even if
there was no match in the field when {{hl.requireFieldMatch=false}}
To me it looks like the requireFieldMatch works as expected, at least with the
default highlighter, so I have not changed any logic. Since it behaves exactly
the same way for alternate field as for the main highlight field I'm not sure
if we need to document anything here either.
Think this is getting close to committable?
> Apply highlighting to hl.alternateField
> ---------------------------------------
>
> Key: SOLR-8583
> URL: https://issues.apache.org/jira/browse/SOLR-8583
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
> Affects Versions: 5.4
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Fix For: 6.1
>
> Attachments: SOLR-8583.patch, SOLR-8583.patch, SOLR-8583.patch,
> SOLR-8583.patch, SOLR-8583.patch
>
>
> Today, you can configure hl.alternateField for highlighter to display if no
> snippets were produced from original field. But the contents of the fallback
> field is output without highlighting the original query terms.
> This issue will cause alternate field to be highlighted with no snippet
> generation, and still respect max length. You can turn it off using new param
> {{hl.highlightAlternate=false}}. Supported highlighters: Simple, FVH
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
