[ 
https://issues.apache.org/jira/browse/SOLR-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Høydahl updated SOLR-8583:
------------------------------
    Attachment: SOLR-8583.patch

bq. You could move this line (that already existed) higher up so that you 
needn't re-pull it out in the highlighting alternate code
Done

bq. why the max(18,altFieldLen) ? 18 seems like a magic number....
FVH requires FRAGSIZE to be at least 18, else there will be an exception. So I 
just set that as the lower limit. Added a comment line in the code: {code}// 
Enforce maxAlternateFieldLength by FRAGSIZE. Minimum 18 due to FVH limitations
{code}

Also added [~dsmiley] as contributor in CHANGES, thanks for all the feedback!

Will go ahead and commit latest patch now.

> Apply highlighting to hl.alternateField
> ---------------------------------------
>
>                 Key: SOLR-8583
>                 URL: https://issues.apache.org/jira/browse/SOLR-8583
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>    Affects Versions: 5.4
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: fallback, highlighter
>             Fix For: 6.1, master (7.0)
>
>         Attachments: SOLR-8583.patch, SOLR-8583.patch, SOLR-8583.patch, 
> SOLR-8583.patch, SOLR-8583.patch, SOLR-8583.patch
>
>
> Today, you can configure hl.alternateField for highlighter to display if no 
> snippets were produced from original field. But the contents of the fallback 
> field is output without highlighting the original query terms.
> This issue will cause alternate field to be highlighted with no snippet 
> generation, and still respect max length. You can turn it off using new param 
> {{hl.highlightAlternate=false}}. Supported highlighters: Simple, FVH



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to