[ 
https://issues.apache.org/jira/browse/SOLR-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345384#comment-15345384
 ] 

Jan Høydahl commented on SOLR-9194:
-----------------------------------

You patch does not apply to master. Are you sure you don't have any local 
commits that you git diff against?
patch cannot find file 
{{solr/core/src/test/org/apache/solr/cloud/SolrCLIZkUtilsTest.java}}, isn't it 
a new file?
Try e.g. {{git diff ece9d85cbea962fd7d327010f1ba184cefdfa8ed}} to diff against 
last master commit?

Also, there is a help print in your patch that says

bq. +    echo "Zookeeper operation (one of 'upconfig', 'downconfig', 
'-upconfig' or  '-downconfig') is required!"

You should probably mention cp, rm, mv there as well?

> Enhance the bin/solr script to put and get arbitrary files to/from Zookeeper
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-9194
>                 URL: https://issues.apache.org/jira/browse/SOLR-9194
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-9194.patch
>
>
> There are a few other files that can reasonably be pushed to Zookeeper, e.g. 
> solr.xml, security.json, clusterprops.json. Who knows? Even 
> <collection>/state.json for the brave.
> This could reduce further the need for bouncing out to zkcli.
> Assigning to myself just so I don't lose track, but I would _love_ it if 
> someone else wanted to take it...
> I'm thinking the commands would be 
> bin/solr zk -putfile -z <ensemble> -p <zookeeper path> -f <local file path>
> bin/solr zk -getfile -z <ensemble> -p <zookeeper path> -f <local file path>
> but I'm not wedded to those, all suggestions welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to