[ 
https://issues.apache.org/jira/browse/SOLR-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347550#comment-15347550
 ] 

Erick Erickson commented on SOLR-9194:
--------------------------------------

Jan:

Thanks for testing and the feedback.

Your "X's"
bq: When mis-typing, such as omitting the -z, we print the error msg followed 
by the full usage. Suggest we instead print the helpful error message followed 
by Type bin/solr zk -help for usage help
 
Done. The long help messages do, indeed, get in the way of figuring out what 
was wrong.

bq: This log msg from CloudSolrClient is annoying:

Made it into a DEBUG rather than INFO.

bq: Typo: Name of the...

fixed

bq: The command bin/solr zk rm -r / succeeds, rendering Solr useless

Well don't do that ;). I put in a check and the script now barfs in that 
situation.

bq: Why do we write "Solr MUST be started on.....

because when I was copying things around during the original 
upconfig/downconfig I used CloudSolrClient like other tools in SolrCLI did and 
there is a check to see if Zookeeper has been initialized. In other words 
because I didn't look at it carefully enough ;) I just proofed out using 
SolrZkClient and at least it works on the 'cp' command. So I should be able to 
convert the rest. That's annoyed me for quite a while but I never tried getting 
around it. Now I have.

bq: Could we wish for a solr zk ls command?
Yep, we sure could. Testing the cp command just made me wish for one, I think 
I'll put it in while I'm at it.

Thanks again! Probably get another patch up this weekend with all this, 
including the ls command.


> Enhance the bin/solr script to put and get arbitrary files to/from Zookeeper
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-9194
>                 URL: https://issues.apache.org/jira/browse/SOLR-9194
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: SOLR-9194.patch, SOLR-9194.patch
>
>
> There are a few other files that can reasonably be pushed to Zookeeper, e.g. 
> solr.xml, security.json, clusterprops.json. Who knows? Even 
> <collection>/state.json for the brave.
> This could reduce further the need for bouncing out to zkcli.
> Assigning to myself just so I don't lose track, but I would _love_ it if 
> someone else wanted to take it...
> I'm thinking the commands would be 
> bin/solr zk -putfile -z <ensemble> -p <zookeeper path> -f <local file path>
> bin/solr zk -getfile -z <ensemble> -p <zookeeper path> -f <local file path>
> but I'm not wedded to those, all suggestions welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to