[
https://issues.apache.org/jira/browse/SOLR-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423309#comment-15423309
]
Danny Teichthal commented on SOLR-7036:
---------------------------------------
[~erickerickson] I followed the HowToContribute wiki.
Please forgive me because I'm newbie on git.
If it matters, I work on windows, with eclipse, git version - 2.9.0.windows.1.
Executed the commands from windows command line.
I pulled the latest version today.
Fixed my old files (currently attached to JIRa as a zip file) to pass
compilation.
I committed my changes to my local repository.
Then, executed patch command:
This is the exact command I executed "git format-patch -w -b origin/master
--stdout > SOLR-7036.patch"
What am I doing wrong?
Meanwhile, I'm uploading a zip file containing my changes.
It contains the directory structure, so it can be just extracted if you are
inside directory "lucene-solr"
> Faster method for group.facet
> -----------------------------
>
> Key: SOLR-7036
> URL: https://issues.apache.org/jira/browse/SOLR-7036
> Project: Solr
> Issue Type: Improvement
> Components: faceting
> Affects Versions: 4.10.3
> Reporter: Jim Musil
> Assignee: Erick Erickson
> Fix For: 5.5, 6.0
>
> Attachments: SOLR-7036.patch, SOLR-7036.patch, SOLR-7036.patch,
> SOLR-7036.patch, SOLR-7036.patch, jstack-output.txt, performance.txt,
> source_for_patch.zip
>
>
> This is a patch that speeds up the performance of requests made with
> group.facet=true. The original code that collects and counts unique facet
> values for each group does not use the same improved field cache methods that
> have been added for normal faceting in recent versions.
> Specifically, this approach leverages the UninvertedField class which
> provides a much faster way to look up docs that contain a term. I've also
> added a simple grouping map so that when a term is found for a doc, it can
> quickly look up the group to which it belongs.
> Group faceting was very slow for our data set and when the number of docs or
> terms was high, the latency spiked to multiple second requests. This solution
> provides better overall performance -- from an average of 54ms to 32ms. It
> also dropped our slowest performing queries way down -- from 6012ms to 991ms.
> I also added a few tests.
> I added an additional parameter so that you can choose to use this method or
> the original. Add group.facet.method=fc to use the improved method or
> group.facet.method=original which is the default if not specified.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
