[
https://issues.apache.org/jira/browse/LUCENE-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427993#comment-15427993
]
Uwe Schindler commented on LUCENE-7419:
---------------------------------------
I agree, the latest patch is the only correct fix. The special case for
PositionIncrement inside the TokenStream base class is just wrong + it adds
overhead in getAttribute. I agree attributes should have the option to say on
their own what they need to do on end!
It would be good to find out when this problem in end() was added. To me thois
code looked completely new, never have seen it before!
> performance bug in tokenstream.end()
> ------------------------------------
>
> Key: LUCENE-7419
> URL: https://issues.apache.org/jira/browse/LUCENE-7419
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Priority: Blocker
> Fix For: master (7.0), 6.2.0
>
> Attachments: LUCENE-7419.patch
>
>
> TokenStream.end() calls getAttribute(), which is pretty costly to do
> per-stream.
> It does its current hack, because in the ctor of TokenStream is "too early".
> Instead, we can just add a variant of clear(), called end() to AttributeImpl.
> For most attributes it defers to clear, but for PosIncAtt it can handle the
> special case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
