[ https://issues.apache.org/jira/browse/LUCENE-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428319#comment-15428319 ]
ASF subversion and git services commented on LUCENE-7419: --------------------------------------------------------- Commit f8536ce72606af6c75cf9137f354da57bb0f3dbc in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f8536ce ] LUCENE-7419: Don't lookup PositionIncrementAttribute every time in TokenStream.end() > performance bug in tokenstream.end() > ------------------------------------ > > Key: LUCENE-7419 > URL: https://issues.apache.org/jira/browse/LUCENE-7419 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Priority: Blocker > Fix For: master (7.0), 6.2.0 > > Attachments: LUCENE-7419.patch > > > TokenStream.end() calls getAttribute(), which is pretty costly to do > per-stream. > It does its current hack, because in the ctor of TokenStream is "too early". > Instead, we can just add a variant of clear(), called end() to AttributeImpl. > For most attributes it defers to clear, but for PosIncAtt it can handle the > special case. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org