[ 
https://issues.apache.org/jira/browse/SOLR-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436868#comment-15436868
 ] 

Mark Miller commented on SOLR-9284:
-----------------------------------

*  1. In BlockDirectoryCache, the map between name and integer is changed to 
use Caffeine cache without setting up removal listener...

It never had a removal listener. This is the names map mentioned above. We 
can't easily remove names, that is the point of just setting an upper size on 
it.

*  2. There are a few occurrences of System.out.println() in 
BlockDirectoryCache. It's better to use log.

This is just debug statements for development, no need to log, they just need 
to be removed before commit.

> The HDFS BlockDirectoryCache should not let it's keysToRelease or names maps 
> grow indefinitely.
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9284
>                 URL: https://issues.apache.org/jira/browse/SOLR-9284
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: hdfs
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 6.2, master (7.0)
>
>         Attachments: SOLR-9284.patch, SOLR-9284.patch
>
>
> https://issues.apache.org/jira/browse/SOLR-9284



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to