[ 
https://issues.apache.org/jira/browse/SOLR-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437826#comment-15437826
 ] 

Ben Manes commented on SOLR-9284:
---------------------------------

Hopefully I didn't break this behavior when upgrading from 
ConcurrentLinkedHashMap (Caffeine's predecessor). That code used an eviction 
listener, so I think it was a direct translation. Can you take a look and see 
if the prior version was more correct?

Note that the cache, in its current form, will only evict after the maximum 
size threshold is crossed. However, Guava does evict prior due to being split 
into multiple segments that are operated on exclusively during a write. I kept 
that wording in the JavaDoc to provide flexibility, just in case.

> The HDFS BlockDirectoryCache should not let it's keysToRelease or names maps 
> grow indefinitely.
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9284
>                 URL: https://issues.apache.org/jira/browse/SOLR-9284
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: hdfs
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 6.2, master (7.0)
>
>         Attachments: SOLR-9284.patch, SOLR-9284.patch
>
>
> https://issues.apache.org/jira/browse/SOLR-9284



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to