[ 
https://issues.apache.org/jira/browse/LUCENE-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487551#comment-15487551
 ] 

ASF subversion and git services commented on LUCENE-7446:
---------------------------------------------------------

Commit b2a0ccdfe1f429f73570f6adbbe22dfae1795df7 in lucene-solr's branch 
refs/heads/branch_5x from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b2a0ccd ]

LUCENE-7446: don't ask about version back-compatibility when we know it's not 
applicable (i.e., the version to be added is greater than the latest on the 
branch)


> Fix back-compat version check in addVersion helper script
> ---------------------------------------------------------
>
>                 Key: LUCENE-7446
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7446
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Minor
>         Attachments: LUCENE-7446.patch, LUCENE-7446.patch
>
>
> As part of the 5.5.3 post-release process, I was trying to bump up the number 
> to 5.5.4 on the release branch but ran into the following error:
> {code}
> Traceback (most recent call last):
>   File "dev-tools/scripts/addVersion.py", line 246, in <module>
>     main()
>   File "dev-tools/scripts/addVersion.py", line 221, in main
>     if current_version.is_back_compat_with(c.version):
>   File 
> "/Users/anshumgupta/workspace/lucene-solr/dev-tools/scripts/scriptutil.py", 
> line 75, in is_back_compat_with
>     raise Exception('Back compat check disallowed for newer version: %s < %s' 
> % (self, other))
> Exception: Back compat check disallowed for newer version: 5.5.3 < 5.5.4
> {code}
> I think the check is wrong and should be reversed. I'll post a patch that I 
> used to work around this but would be good to have more eyes on this before I 
> commit this.
> [~steve_rowe]: Can you take a look at the patch as I guess you added this 
> recently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to