[ https://issues.apache.org/jira/browse/LUCENE-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487681#comment-15487681 ]
Anshum Gupta commented on LUCENE-7446: -------------------------------------- Thanks Steve! That makes sense and I kind of knew (and mentioned in my comment) that my fix wasn't completely correct but I used it because it got me through the release process for 5.5.3. > Fix back-compat version check in addVersion helper script > --------------------------------------------------------- > > Key: LUCENE-7446 > URL: https://issues.apache.org/jira/browse/LUCENE-7446 > Project: Lucene - Core > Issue Type: Bug > Reporter: Anshum Gupta > Assignee: Anshum Gupta > Priority: Minor > Fix For: master (7.0), 6.0.2, 6.1.1, 5.6, 6.3, 5.5.4, 6.2.1 > > Attachments: LUCENE-7446.patch, LUCENE-7446.patch > > > As part of the 5.5.3 post-release process, I was trying to bump up the number > to 5.5.4 on the release branch but ran into the following error: > {code} > Traceback (most recent call last): > File "dev-tools/scripts/addVersion.py", line 246, in <module> > main() > File "dev-tools/scripts/addVersion.py", line 221, in main > if current_version.is_back_compat_with(c.version): > File > "/Users/anshumgupta/workspace/lucene-solr/dev-tools/scripts/scriptutil.py", > line 75, in is_back_compat_with > raise Exception('Back compat check disallowed for newer version: %s < %s' > % (self, other)) > Exception: Back compat check disallowed for newer version: 5.5.3 < 5.5.4 > {code} > I think the check is wrong and should be reversed. I'll post a patch that I > used to work around this but would be good to have more eyes on this before I > commit this. > [~steve_rowe]: Can you take a look at the patch as I guess you added this > recently. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org