Fixed the behavior in Revision: 1097097
simon
On Tue, Apr 26, 2011 at 6:14 PM, Shai Erera <ser...@gmail.com> wrote:
> I think you're right Simon !
>
> Obviously I didn't test it with that scenario in mind :).
>
> Shai
>
> On Tue, Apr 26, 2011 at 6:15 PM, Simon Willnauer
> <simon.willna...@googlemail.com> wrote:
>>
>> hey I wonder how this TEST_MIN_ITER feature works though...
>> I expect that if I set -Dtests.iter.min=1 -Dtests.iter=10 and I fail
>> in any of those iterations that the the runner stops immediately and
>> prints a failure. Is that correct?
>>
>> if so I don't understand this code:
>>
>> if (testsFailed) {
>> lastIterFailed = i;
>> if (i == TEST_ITER_MIN - 1) {
>> if (verbose) {
>> System.out.println("\nNOTE: iteration " + lastIterFailed + " failed
>> !");
>> }
>> break;
>> }
>> }
>>
>> this only stops if it fails at tests.iter.min but not if it has failed
>> test.iter.min+1
>> This should rather be something like if(i >=TEST_ITERM_MIN-1) right?
>>
>> simon
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
