[ https://issues.apache.org/jira/browse/SOLR-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15598675#comment-15598675 ]
Christine Poerschke commented on SOLR-9641: ------------------------------------------- bq. This is really cool Mike Drob! ... +1 to that, I am also looking forward to having tracing support in Solr. Here's my comments from looking at the patch: * minor: in CoreContainer there is one {{zkSys.getZkController().getNodeName()}} and one {{getZkController().getNodeName()}} call, they could be combined into one call with result kept in local variable or both could use or not use {{zkSys}} for clarity. * In SearchHandler, how about also having trace scopes for the {{handleResponses}} and {{finishStage}} steps? Or if the intention is to only trace component methods which typically make requests to other shards maybe not trace the {{prepare}} step? * In CoreAdminHandler for the {{callInfo.call();}} there is the {{traceDescription + " async"}} scope i.e. differentiation between sync and async. Just wondering if something similar might be useful for SearchHandler's without-debug and with-debug prepare and process scopes? * In the tests, curious why only \[0\] is being added in the getReceivers methods? * In the tests, might the {{Random random()}} method be passed down to SpanId i.e. for the tests {code} - ... SpanId.fromRandom() ... + ... SpanId.fromRandom(random()) ... {code} and for [SpanId.java|https://github.com/apache/incubator-htrace/blob/master/htrace-core4/src/main/java/org/apache/htrace/core/SpanId.java] something along the lines of {code} + import java.util.Random; + + private static long nonZeroRand64(Random random) { + while (true) { + long r = random.nextLong(); + if (r != 0) { + return r; + } + } + } + + public static SpanId fromRandom(Random random) { + return new SpanId(nonZeroRand64(random), nonZeroRand64(random)); + } {code} > Emit distributed tracing information from Solr > ---------------------------------------------- > > Key: SOLR-9641 > URL: https://issues.apache.org/jira/browse/SOLR-9641 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Mike Drob > Fix For: master (7.0) > > Attachments: SOLR-9641.patch > > > While Solr already offers a few tools for exposing timing, this information > can be difficult to aggregate and analyze. By integrating distributed tracing > into Solr operations, we can gain new performance and behaviour insights. > One such solution can be accomplished via Apache HTrace (incubating). > (More rationale to follow.) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org