[
https://issues.apache.org/jira/browse/SOLR-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603141#comment-15603141
]
Mike Drob commented on SOLR-9641:
---------------------------------
bq. in CoreContainer there is one zkSys.getZkController().getNodeName() and one
getZkController().getNodeName() call, they could be combined into one call with
result kept in local variable or both could use or not use zkSys for clarity.
Done.
bq. In SearchHandler, how about also having trace scopes for the
handleResponses and finishStage steps? Or if the intention is to only trace
component methods which typically make requests to other shards maybe not trace
the prepare step?
Hmm... yes, this could make sense. I didn't want to put too much in for the
distributed request portion because that also gets traced on the remote peers.
But you're right that something should be looked at here. Adding it around only
handleResponse and finishStage seems insufficient? There is a lot of other
things going on in the distribute branch there. Will come back to this later...
bq. In CoreAdminHandler for the callInfo.call(); there is the traceDescription
+ " async" scope i.e. differentiation between sync and async. Just wondering if
something similar might be useful for SearchHandler's without-debug and
with-debug prepare and process scopes?
You mean labelling the debug scope with a debug description? Yea, that's
doable. My async description was largely a hack, I think, and will probably go
away in favor of something more generic.
bq. In the tests, curious why only [0] is being added in the getReceivers
methods?
Because there was only one receiver configured per jetty. I'll change this to
grab them all.
bq. In the tests, might the Random random() method be passed down to SpanId
Good idea. I'll make a utility method in Solr for now, but also filed HTRACE-391
> Emit distributed tracing information from Solr
> ----------------------------------------------
>
> Key: SOLR-9641
> URL: https://issues.apache.org/jira/browse/SOLR-9641
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mike Drob
> Fix For: master (7.0)
>
> Attachments: SOLR-9641.patch
>
>
> While Solr already offers a few tools for exposing timing, this information
> can be difficult to aggregate and analyze. By integrating distributed tracing
> into Solr operations, we can gain new performance and behaviour insights.
> One such solution can be accomplished via Apache HTrace (incubating).
> (More rationale to follow.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
