[
https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-5325:
----------------------------------
Attachment: LUCENE-5325.patch
Thanks for the review, Adrien. Here's an updated patch:
* advanceTo renamed to advanceExact
* fromIntField delegates to fromLongField in both Long and DoubleValuesSource
* I ended up removing the automatic wrapping of doubles to longs in
LongValuesSource entirely, in favour of calling
DoubleValuesSource.toLongValuesSource(). The javadocs on the latter now
explicitly say that the conversion is done via casting.
* Javadocs generally are more explanatory, particularly around scores
* getValues() now takes a DoubleValues object rather than a Scorer - this ended
up being a very nice change, and will allow us to remove several of the
FakeScorer implementations that the current ValueSource API forces us to use in
things like expressions or facets.
I'll open a separate issue for adding the throws clause for
FieldComparator.setScorer().
> Move ValueSource and FunctionValues under core/
> -----------------------------------------------
>
> Key: LUCENE-5325
> URL: https://issues.apache.org/jira/browse/LUCENE-5325
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Shai Erera
> Attachments: LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch
>
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs
> which exist under the queries/ module. That causes any module which wants to
> depend on these APIs (but not necessarily on any of their actual
> implementations!), to depend on the queries/ module. If we move these APIs
> under core/, we can eliminate these dependencies and add some mock impls for
> testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the
> expressions/ on queries, the grouping/ dependency on queries, the spatial/
> dependency on queries, its a mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
