[
https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799047#comment-15799047
]
Adrien Grand commented on LUCENE-7609:
--------------------------------------
bq. The dependency on queries is kept for the moment, and the ValueSource
versions of methods deprecated; these will be removed in a subsequent patch.
Why didn't you remove them in this patch? This change is breaking anyway, so
maybe we should make things clean right away? For instance, I'm looking at the
deprecated {{SimpleBindings.getValueSource}} which is not expected to be called
by users of the expression module, so maybe we should remove it now?
> Refactor expressions module to use DoubleValuesSource
> -----------------------------------------------------
>
> Key: LUCENE-7609
> URL: https://issues.apache.org/jira/browse/LUCENE-7609
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Attachments: LUCENE-7609.patch
>
>
> With DoubleValuesSource in core, we can refactor the expressions module to
> use these instead of ValueSource, and remove the dependency of expressions on
> the queries module in master.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
