[ https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799061#comment-15799061 ]
Adrien Grand commented on LUCENE-7609: -------------------------------------- Also this change seems to be changing expression values to not have a value if any of the sub sources does not have a value while in the past it looks like all documents would have a value and we would treat sub sources that do not have a value as zero. I think we should either preserve this behaviour or document the new one? > Refactor expressions module to use DoubleValuesSource > ----------------------------------------------------- > > Key: LUCENE-7609 > URL: https://issues.apache.org/jira/browse/LUCENE-7609 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Attachments: LUCENE-7609.patch > > > With DoubleValuesSource in core, we can refactor the expressions module to > use these instead of ValueSource, and remove the dependency of expressions on > the queries module in master. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org