[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899790#comment-15899790
]
Hoss Man commented on SOLR-10235:
---------------------------------
Uwe: i like this approach, three nits...
1) the javadocs for MockDriver should explain the purpose of this class given
how much of the rest of the outer class uses Mockito.
2) I don't like that you're shadowing the variable named {{driver}} ... at
first glance this could confuse people skimming code who have already seen the
class level {{driver}} variable ... better to use {{mockDriver}} or
{{fixedClassDriver}} or something like that.
3) rather then returning null, I suggest {{MockDriver.connect(...)}} throw a
{{new SQLException("attempted to use this driver with bogus url")}} if
{{acceptsURL(...)}} is false -- so if the day comes when someone breaks the
code, they'll have a decent error msg to identify the bug instead of an NPE.
> fix last TestJdbcDataSource / mock issue with java9
> ---------------------------------------------------
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Labels: java9
> Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch,
> SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
