[ https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900161#comment-15900161 ]
ASF subversion and git services commented on SOLR-10235: -------------------------------------------------------- Commit d8442070cfbb0cec815a465a6c143e2b31870e34 in lucene-solr's branch refs/heads/master from [~thetaphi] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d844207 ] SOLR-10235: fix precommit > fix last TestJdbcDataSource / mock issue with java9 > --------------------------------------------------- > > Key: SOLR-10235 > URL: https://issues.apache.org/jira/browse/SOLR-10235 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Uwe Schindler > Labels: java9 > Fix For: 6.5, master (7.0) > > Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch, > SOLR-10235.patch, SOLR-10235.patch > > > The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still > left one outstanding test that was incompatible with Java9: > {{testRetrieveFromDriverManager()}} > The way this test worked with mock classes was also sketchy, but under java9 > (even with Mockito) the attempt at using class names to resolve things in the > standard SQL DriverManager isn't viable. > It seems like any easy fix is to create _real_ class (with a real/fixed > classname) that acts as a wrapper around a mockito "Driver" instance just for > the purposes of checking that the DriverManaer related code is working > properly. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org