Thanks, I've pushed the change to the 6.6 branch. On Tue, May 23, 2017 at 8:42 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote:
> Sure Martijn, please go ahead. Thanks. > > On Tue, May 23, 2017 at 11:14 PM, Martijn v Groningen < > martijn.v.gronin...@gmail.com> wrote: > >> Hi Ishan, >> >> I like to backport LUCENE-7810 to the 6.6 branch. Is that okay with you? >> >> Martijn >> >> On Tue, May 23, 2017 at 7:02 PM Ishan Chattopadhyaya < >> ichattopadhy...@gmail.com> wrote: >> >>> Thanks Adrien! +1 for the LUCENE-7847 merge. >>> >>> On Tue, May 23, 2017 at 10:20 PM, Adrien Grand <jpou...@gmail.com> >>> wrote: >>> >>>> Hi Ishan, >>>> >>>> I closed LUCENE-7573 which is actually not a problem. We thought it >>>> would be buggy or at least trappy given another bug that was discovered but >>>> the merge logic actually uses the doc-values API in a way that there should >>>> not be problems. >>>> >>>> I took the opportunity of the respin to merge >>>> https://issues.apache.org/jira/browse/LUCENE-7847 to 6.6, hopefully >>>> that's ok with you. I can still revert if that does not work for you or if >>>> you already started building the RC. >>>> >>>> Le lun. 22 mai 2017 à 22:35, Ishan Chattopadhyaya < >>>> ichattopadhy...@gmail.com> a écrit : >>>> >>>>> * I see that LUCENE-7573 is an outstanding blocker for 6.6, but it >>>>> doesn't have a patch and nor has it been updated since March. >>>>> * I see no other issues marked as a blocker. Can someone aware of the >>>>> issues discussed above please mark them as a blocker if they absolutely >>>>> need to go into 6.6? >>>>> >>>>> If there is no update about LUCENE-7573 or any other blockers (apart >>>>> from LUCENE-7573) in another 24 hours from now, I'm planning to downgrade >>>>> LUCENE-7573 from Blocker to Major and start building the next RC. Please >>>>> let me know if there are any objections. >>>>> >>>>> >>>>> On Fri, May 19, 2017 at 8:14 PM, Ishan Chattopadhyaya < >>>>> ichattopadhy...@gmail.com> wrote: >>>>> >>>>>> +1 to respin, and have fixes to LUCENE-7833 included. >>>>>> Uwe, I guess the V2 standalone mode issue is SOLR-10711. Do you >>>>>> consider it as a blocker? If so, can we mark it as such on the JIRA? Is >>>>>> there an issue for the Windows space issue? >>>>>> As for SOLR-10004, I don't think it is a release blocker; however a >>>>>> nice one to fix before the re-spin, if possible. I'd be glad to >>>>>> reconsider, >>>>>> if someone thinks otherwise. >>>>>> >>>>>> On Fri, May 19, 2017 at 6:40 PM, Christine Poerschke (BLOOMBERG/ >>>>>> LONDON) <cpoersc...@bloomberg.net> wrote: >>>>>> >>>>>>> The "javadocs want to fail" output sounds like >>>>>>> https://issues.apache.org/jira/browse/SOLR-10004 ticket. >>>>>>> >>>>>>> From: dev@lucene.apache.org At: 05/17/17 18:44:36 >>>>>>> To: dev@lucene.apache.org >>>>>>> Subject: Re: [VOTE] Release Lucene/Solr 6.6.0 RC1 >>>>>>> >>>>>>> The smoke tester ended with: >>>>>>> >>>>>>> SUCCESS! [0:59:34.797969] >>>>>>> >>>>>>> However, after looking at some of its output, I see a: >>>>>>> ***WARNING***: javadocs want to fail! >>>>>>> Which followed many "missing: ..." messages akin to this: >>>>>>> >>>>>>> unpack solr-6.6.0-src.tgz... >>>>>>> >>>>>>> make sure no JARs/WARs in src dist... >>>>>>> >>>>>>> run "ant validate documentation-lint" >>>>>>> >>>>>>> run tests w/ Java 8 and testArgs=''... >>>>>>> >>>>>>> generate javadocs w/ Java 8... >>>>>>> >>>>>>> >>>>>>> >>>>>>> /tmp/smoke_lucene_6.6.0_4d055f00bba9a745737e4b6c3f9dff06dd35aa2e/unpack/solr-6.6.0/solr/build/docs/solr-analytics/org/apache/solr/analytics/expression/package-summary.html >>>>>>> >>>>>>> missing: ExpressionFactory >>>>>>> >>>>>>> >>>>>>> >>>>>>> /tmp/smoke_lucene_6.6.0_4d055f00bba9a745737e4b6c3f9dff06dd35aa2e/unpack/solr-6.6.0/solr/build/docs/solr-analytics/org/apache/solr/analytics/plugin/package-summary.html >>>>>>> >>>>>>> missing: AnalyticsStatisticsCollector >>>>>>> >>>>>>> >>>>>>> On Wed, May 17, 2017 at 9:49 AM Ishan Chattopadhyaya < >>>>>>> is...@apache.org> wrote: >>>>>>> >>>>>>>> Please vote for release candidate 1 for Lucene/Solr 6.6.0 >>>>>>>> >>>>>>>> The artifacts can be downloaded from: >>>>>>>> >>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.6.0-RC1-rev4d055f00bba9a745737e4b6c3f9dff06dd35aa2e >>>>>>>> <https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.5.0-RC1-rev4b16c9a10c3c00cafaf1fc92ec3276a7bc7b8c95> >>>>>>>> >>>>>>>> You can run the smoke tester directly with this command: >>>>>>>> >>>>>>>> python3 -u dev-tools/scripts/smokeTestRelease.py \ >>>>>>>> >>>>>>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.6.0-RC1-rev4d055f00bba9a745737e4b6c3f9dff06dd35aa2e >>>>>>>> <https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.5.0-RC1-rev4b16c9a10c3c00cafaf1fc92ec3276a7bc7b8c95> >>>>>>>> >>>>>>>> Here's my +1 >>>>>>>> SUCCESS! [0:32:20.501484] >>>>>>>> >>>>>>> -- >>>>>>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >>>>>>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >>>>>>> http://www.solrenterprisesearchserver.com >>>>>>> >>>>>>> >>>>>> >>>>> >>> >